Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Non-UTF8 ID breaking the WatermelonDB roles collection. #5989

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 13, 2024

Proposed changes

The solution to fix the WMDB issue involves encoding non-UTF8 IDs to ensure they are properly handled. Before sending them to the Redux dispatch, the non-UTF8 IDs are decoded. Additionally, if the roles collection is already corrupted, the code now resets the collection and refills it, ensuring smooth operation.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-721

How to test or reproduce

  • Run the code without my updates and edit the getRoles function at line 84 to force a role with a non-UTF8 ID. Update the code to include:
roles.push({
    _id: 'テストDb壊れた', // Non-UTF8 characters in ID
    description: 'Admin',
    mandatory2fa: false,
    protected: true,
    scope: 'Users',
    name: 'admin'
});
  • Restart the app. You should see an error occur due to the non-UTF8 ID.
  • Apply my updates, restart the app, and observe. If the error occurs once, the roles collection will reset, and getRoles will execute again without errors.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant