Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): NewServerView #5951

Merged
merged 10 commits into from
Nov 19, 2024
Merged

chore(a11y): NewServerView #5951

merged 10 commits into from
Nov 19, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 5, 2024 •
edited by jira bot
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

MA-180

@OtavioStasiak OtavioStasiak force-pushed the chore-a11y-form-standard-new-server branch from 42bcb6e to a0839c4 Compare November 14, 2024 15:58
@diegolmello diegolmello changed the title chore: a11y New Server form standard chore(a11y): NewServerView Nov 14, 2024
@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 14, 2024 21:33
@diegolmello diegolmello force-pushed the chore-a11y-form-standard-new-server branch from 3fe01ad to a03d383 Compare November 19, 2024 13:53
diegolmello
diegolmello approved these changes Nov 19, 2024
View reviewed changes
app/containers/TextInput/FormTextInput.tsx Outdated Show resolved Hide resolved
app/views/NewServerView/ServerInput/index.tsx Outdated Show resolved Hide resolved
@diegolmello diegolmello merged commit 242fc12 into develop Nov 19, 2024
8 of 13 checks passed
@diegolmello diegolmello deleted the chore-a11y-form-standard-new-server branch November 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtavioStasiak @diegolmello