This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
introduce Roles bridge #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapiarafael
previously approved these changes
Aug 2, 2023
tapiarafael
approved these changes
Aug 7, 2023
d-gubert
reviewed
Aug 7, 2023
Comment on lines
143
to
+146
| AppPermissions.moderation.read, | ||
| AppPermissions.moderation.write, | ||
| AppPermissions.role.read, | ||
| AppPermissions.role.write, |
There was a problem hiding this comment.
@Dnouv please remove these permissions from the default list. The default list shouldn't really change anymore, since it is used to not break apps that were developed PRIOR to the permission system.
There was a problem hiding this comment.
Thank you! Resolved in #655
tiagoevanp
added a commit
that referenced
this pull request
Aug 25, 2023
This reverts commit a6eefe2.
tiagoevanp
added a commit
that referenced
this pull request
Aug 28, 2023
This reverts commit 2822672.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
idorname.Why? 🤔
Links 🌎
WM-149
RocketChat/Rocket.Chat#29968
PS 👀