-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging devel to master #4
base: master
Are you sure you want to change the base?
Conversation
Wagram devel
# Conflicts: # README.md
Merge updated ontology to devel
Merge updates to devel
Removed deb package builder from pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
future("future"), | ||
birthdate("birthdate"), | ||
facebook_id("facebook_id"), | ||
telegram_id("telegram_id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not have a only a single property called UUID.
Combining the Node Label with a single Social Media Service ID (aka UUID), would be enough, wouldn't it be? Every social media API worth its salt should in theory have their ID be unique, therefore we can identify each user by using the Label + Property.
It would save us the need of having to specify the property of each new media.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit vs. implicit; let's ask botboy
Robot("Robot"), | ||
Company("Company"), | ||
University("University"), | ||
City("City"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually plan on using city? AFAIK only the Roboy node is the only thing that uses City and that can be changed.
Afterall, confusingly enough, we ask for a town in the questions, when we save it as country...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, yes. It is a question of grounding to the DBpedia. Stays for compatibility sure thing
slack_id("slack_id"), | ||
whatsapp_id("whatsapp_id"), | ||
line_id("line_id"), | ||
color("color"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is color used for?
Sorry, can't Uzupis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uzupis is a mystery, lol
First meaningful update of the master branch
Contains