Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging devel to master #4

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Merging devel to master #4

wants to merge 26 commits into from

Conversation

Waguramu
Copy link
Member

First meaningful update of the master branch

  • initial for the future extension

Contains

  • ontology based on Neo4jLabels, Neo4jProperties, Neo4jRelationships
  • ontology constraints for Interlocutor and Roboy
  • definition of an abstract NodeModel

@Waguramu Waguramu self-assigned this Aug 26, 2018
@Waguramu Waguramu added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2018
Copy link

@Aevyz Aevyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

future("future"),
birthdate("birthdate"),
facebook_id("facebook_id"),
telegram_id("telegram_id"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not have a only a single property called UUID.

Combining the Node Label with a single Social Media Service ID (aka UUID), would be enough, wouldn't it be? Every social media API worth its salt should in theory have their ID be unique, therefore we can identify each user by using the Label + Property.

It would save us the need of having to specify the property of each new media.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit vs. implicit; let's ask botboy

Robot("Robot"),
Company("Company"),
University("University"),
City("City"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually plan on using city? AFAIK only the Roboy node is the only thing that uses City and that can be changed.

Afterall, confusingly enough, we ask for a town in the questions, when we save it as country...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, yes. It is a question of grounding to the DBpedia. Stays for compatibility sure thing

slack_id("slack_id"),
whatsapp_id("whatsapp_id"),
line_id("line_id"),
color("color");
Copy link

@Aevyz Aevyz Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is color used for?

Sorry, can't Uzupis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uzupis is a mystery, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants