Reduce Tabs component re-renders and fix controlled component functionality #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfagan2
suggested changes
Jan 19, 2022
| onTabChange(item) | ||
| } | ||
| }, | ||
| [onTabChange] |
There was a problem hiding this comment.
shouldn't item also be included in the dependencies here? just in case it were to change?
| isActive={selectedTab === item.label} | ||
| key={index} | ||
| item={item} | ||
| onTabChange={() => handleTabChange(item)} |
There was a problem hiding this comment.
to avoid having this be an inline anonymous function, which can effect re-renders, I think you can just make this onTabChange={handleTabChange}, because when you call it now from within the Tab component, you send the item as an argument there, which the function definition is equipped to handle
| @@ -22,12 +30,33 @@ export const Normal = ({ themeName }) => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <Tabs | |||
| <FormCheckbox | |||
There was a problem hiding this comment.
This is a good idea, but should be governed as a story "Knob", rather than an on page element. See the componentKnobs of other stories like FormInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various optimizations and
<Tab />component tree isolation to reduce renders and re-mounts.Adds a checkbox and proper state to the story to show the component working as a controlled component.