Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System checks #227

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

System checks #227

wants to merge 26 commits into from

Conversation

NikhilSuresh24
Copy link
Member

Made automated system check framework for the robot

Daniel-E-B
Daniel-E-B requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@Daniel-E-B Daniel-E-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. we should do a full test of all of this on the robot to tune all of the constants (some of which should maybe be stored somewhere in yearly code?). Also change the logkitten levels back

subsystems/motor/PositionSensorMotor.java Outdated Show resolved Hide resolved
commands/systemchecks/motor/SensorMotorCheck.java Show resolved Hide resolved
commands/systemchecks/motor/MotorCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/motor/MotorCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/TurnPIDCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/DrivePIDCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/DrivePIDCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/CompressorCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/CheckGroup.java Outdated Show resolved Hide resolved
commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
billwpierce
billwpierce requested changes Feb 4, 2019
View reviewed changes
Copy link
Member

@billwpierce billwpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at my comments. It looks fine, and I might just be misunderstanding the changes, but I'd like clarification on some things.

commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/BasicCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/motor/MotorCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/motor/PositionMotorCheck.java Show resolved Hide resolved
commands/systemchecks/motor/SensorMotorCheck.java Show resolved Hide resolved
commands/systemchecks/motor/ServoCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/motor/ServoCheck.java Outdated Show resolved Hide resolved
billwpierce
billwpierce requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@billwpierce billwpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of small changes, but looks mostly good

commands/systemchecks/BatteryCheck.java Show resolved Hide resolved
commands/systemchecks/DrivePIDCheck.java Outdated Show resolved Hide resolved
commands/systemchecks/DrivePIDCheck.java Show resolved Hide resolved
commands/systemchecks/DrivePIDCheck.java Show resolved Hide resolved
commands/systemchecks/NetworkTablesCheck.java Show resolved Hide resolved
commands/systemchecks/SolenoidCheck.java Show resolved Hide resolved
commands/systemchecks/TurnPIDCheck.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codadillo Codadillo Codadillo left review comments

@billwpierce billwpierce billwpierce requested changes

@Daniel-E-B Daniel-E-B Daniel-E-B requested changes

@oshlern oshlern Awaiting requested review from oshlern

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikhilSuresh24 @Daniel-E-B @billwpierce @Codadillo