Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logkitten improvements #216
base: main
Are you sure you want to change the base?
Logkitten improvements #216
Changes from 9 commits
d7d90ac
fd179c6
2a2ab49
042efe4
f00f396
b886697
416e1cd
eee9ff3
a06e805
3445734
0db9826
26a55d6
8860a3d
0e1fcae
4c765bf
7263bb9
1d8defa
a6403e7
a634f65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of duplicate code between "RobotModeKitten" and "CANKitten" cases. The code:
Could probably be reduced to a private method, or maybe a better flow could be worked out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it might be better instead to move the
logMessage
method to theKitten
class itself, and haveLogKitten
extendKitten
or something of that sort. Looking at a screen is making me nauseous right now but I can take a closer look tomorrow hopefully.