Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSeverity is just a pointless wrapper for ordinal #210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

getSeverity is just a pointless wrapper for ordinal #210

wants to merge 3 commits into from

Conversation

leijurv
Copy link
Contributor

@leijurv leijurv commented Jan 7, 2018 •
edited
Loading

see title. i changed it so it isn't

@oldgalileo oldgalileo self-requested a review January 7, 2018 05:35
@oldgalileo
Copy link
Contributor

Please test and verify the logging is consistent. Then will merge.

@leijurv
Copy link
Contributor Author

leijurv commented Jan 7, 2018

R u kidding me look at it lmao

@ajnadel
Copy link
Member

ajnadel commented Jan 9, 2018

@leijurv add real PR name and description.

@leijurv leijurv changed the title Update LogKitten.java getSeverity is just a pointless wrapper for ordinal Jan 9, 2018
@b-cho b-cho self-requested a review January 17, 2020 01:52
b-cho
b-cho approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@b-cho b-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

@b-cho b-cho added merge-ready Ready to merge and removed ready for testing labels Jan 17, 2020
@leijurv
Copy link
Contributor Author

leijurv commented Jan 17, 2020

@bcho04 #207 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-cho b-cho b-cho approved these changes

@oldgalileo oldgalileo Awaiting requested review from oldgalileo

Assignees
No one assigned
Labels
merge-ready Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leijurv @oldgalileo @ajnadel @b-cho