Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styleguide commit and sha256 #22409

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachfang
Copy link
Contributor

@zachfang zachfang commented Jan 7, 2025

Copy link
Contributor Author

@zachfang zachfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to RobotLocomotion/styleguide#55
+@jwnimmer-tri for feature and +@ggould-tri for platform review, thanks!
(Let me know if the order of the operation is wrong.)

Reviewable status: 1 unresolved discussion, LGTM missing from assignees jwnimmer-tri(platform),ggould-tri(platform), missing label for release notes (waiting on @zachfang)


tools/workspace/styleguide/repository.bzl line 9 at r1 (raw file):

        name = name,
        repository = "RobotLocomotion/styleguide",
        commit = "b914285784092231fab393c2b8d79f8e3495b297",

Working. Change to the final commit once the associated PR is merged.

Code quote:

b914285784092231fab393c2b8d79f8e3495b297

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignees ggould-tri(platform),jwnimmer-tri(platform), missing label for release notes (waiting on @zachfang)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants