Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Factor to single point of control for Fortran #22398

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 5, 2025

As with recent work on to centralize C++ and Python toolchains, changes Drake's citations for Fortran targets and macros to use a single point of control.

Towards #20731. (This will allow downstream code like Anzu to call the snopt_repository rule without ever directly depending on @gfortran.)


This change is Reviewable

As with recent work on to centralize C++ and Python toolchains,
changes Drake's citations for Fortran targets and macros to use
a single point of control.

Also removes a vestigial version check now that Jammy is our oldest
supported platform.
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Jan 5, 2025
@jwnimmer-tri
Copy link
Collaborator Author

+@ggould-tri for both reviews per schedule, please.

FYI @rpoyner-tri in the past I believe you asked about whether fortran.bzl should really live in tools/workspace/snopt. Now it doesn't.

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit 0f6b941 into RobotLocomotion:master Jan 7, 2025
10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the bzlmod-fortran branch January 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants