Improve how we manage which PDM to use #22378
Open
+73
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwoehlke-kitware
force-pushed
the
pdm-update-self
branch
from
bc2213d to
3a05c50
Compare
mwoehlke-kitware
changed the title
mwoehlke-kitware
force-pushed
the
pdm-update-self
branch
from
3a05c50 to
bbcddc4
Compare
Move our PDM version pin to a separate file. This both makes it easier to manage updates to the same and also allows the pinned version to be usable outside of the venv_sync script. Add a simple script to update version pins in this file. Teach venv_upgrade to use this to update the PDM version pin in addition to updating the PDM lock file. Also, modify venv_sync to tell PDM to not complain about newer versions.
mwoehlke-kitware
force-pushed
the
pdm-update-self
branch
from
bbcddc4 to
3644705
Compare
|
+@BetsyMcPhail for feature review, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move our PDM version pin to a separate file. This both makes it easier to manage updates to the same and also allows the pinned version to be usable outside of the
venv_syncscript. Add a simple script to update version pins in this file. Teachvenv_upgradeto use this to update the PDM version pin in addition to updating the PDM lock file. Also, modifyvenv_syncto tell PDM to not complain about newer versions.Toward #22040.
This change is