Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solvers] Fix MobyLCPSolver to use Drake logging not cerr #22359

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Dec 30, 2024

Deprecate its bespoke SetLoggingEnabled.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: newly deprecated This pull request contains new deprecations labels Dec 30, 2024
Deprecate its bespoke SetLoggingEnabled.
@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for all reviews, please.

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sammy-tri(platform)

@sammy-tri sammy-tri merged commit b72cb42 into RobotLocomotion:master Jan 9, 2025
10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the moby-logging branch January 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: newly deprecated This pull request contains new deprecations status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants