Hotfix for rosidl cpp visibility header addition #371
Conversation
There was a problem hiding this comment.
+@IanTheEngineer for review.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
I am in agreement that finding and using the actual template file on disk is preferable to having it here in string form. For future reference, the file is now located here:
/opt/ros/humble/share/rosidl_generator_cpp/resource/rosidl_generator_cpp__visibility_control.hpp.in
With that said, the required Bazel-structure to access this file is not immediately clear, so I am okay leaving this as a TODO for now.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @calderpg-tri)
|
Let me know if you want me to force this into |
calderpg-tri
changed the title
There was a problem hiding this comment.
I've changed the title slightly. I believe @IanTheEngineer is going to try to fix the CI configuration here, but it's probably fine to force it into main for now.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @IanTheEngineer)
|
Okay, I've confirmed that the CI failure is not reproducible locally. I'll force this in now. |
|
I was about to comment the same thing! I cannot reproduce the CI failure either. Thanks for merging, Jeremy. |
|
I think the failure happens when the older ROS packages are installed but the newer code is being run -- and because the GHA CI doesn't run |
This change is