-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narration Capture Mode #48
base: development
Are you sure you want to change the base?
Conversation
… with windows. TODO: Change it back when I make the final commit.
…d by CRt_ViewManagerASB.java
Added Config.json variable - content_creation_mode in order to enable narrate mode Added empty methods to CRt_ViewManagerMari.java - they may need to be filled in if this class is actually used Added FTR_NARRATE_MODE to TCONST
…into narrate_mode
- Added ability to launch tutor using debug.json - Finished saving feature (storydata.json is edited accordingly) - Added segmentation information - Added necessary framework for story navigation (UI needs to be made)
-remove_noise and -remove_silence set to false in ListenerBase
… into narrate_mode
Steps: go to line 1838 of CRt_ViewManagerASB.java and make sure doNotTruncate is set to true if you want to NOT truncate, and FALSE if you want mean mode as usual
- now the code for debug.json doesn't need to be changed in order to add a new variable
- Still need to figure out why the last word is sometimes omitted
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Merging master into anything surprised me. Was merging master into narrate_mode the way you incorporated the master commits made between your first narrate_mode commit on 8/26/2020 and the most recent master commit on 1/11/2021? Does narrate_mode actually depend on any of those commits? I assume it doesn't depend on any subsequent commits to development, which will get included by merging narrate_mode into development.
-
The config.json here works only for English. Instead of specifying a particular config.json, please specify just the particular settings required for narration.
-
Why "content_creation_mode": false? Shouldn't it be true for narrate_mode?
-
@sansyrox - The apk branch doesn't yet have an apk for narrate_mode. I thought issuing a PR to development generates an apk automatically, but it didn't yet. I gather it requires something more, namely what -- resolving conflicts?
@JackMostow , there are many conflicts that need to be resolved. After that the apk generation will be triggered. |
|
3f984cd#diff-12643fc3c660cc99685c264511694814e6afa617510fb2b557f2f3892701629e |
I'll need to fix the gradle issues with compiling the apk and upload to GDrive accordingly. |
@chirag03k - I think an apk won't get auto-generated until the branch passes automated checks that it currently doesn't. |
I resolved all the merge conflicts, but it was a little messy because I used vscode and accidentally updated some configuration files. Hopefully an apk can be autogenerated now. |
…ure mode from starting
…tead of relying on echo functionality
* Improve cloud scripts * Add more docs * Add script for automatic apk generation * Update travis scripts
* Build pipeline final commit * Add more changes * Update * Add final token
* Build pipeline script bug fix * Add more descriptive commit message
* Add the git hook for automatic version numbering * Add documentation * Version number included in apk filename Co-authored-by: Sushant <[email protected]>
I cherry-picked commits from development that weren't merging into narrate_mode becuase they were integral to the functioning of travis. I also resolved the conflicts on github. |
…narrated by the recording is being highlighted
@chirag03k #48 for narrate_mode still has conflicts in comp_listener/src/main/java/edu/cmu/xprize/listener/SpeechRecognizer.java to resolve. Can you do it? |
Initial PR for Narration Capture Mode
See Issue #40 for more information on the capabilities and limitations of this right now.
Directions for Use
STEP 1: Create storydata.json for a particular story, but leave out segmentation and narration data in the storydata.json file
STEP 2: In the downloads folder of the android device, create a folder with the story title, and in it create another folder with the story title + an underscore + a level number (e.g. if the story was titled, say, "butterflies" and the level was "1", you should have the file structure "Downloads/butterfly/butterflies_1"). Save the storydata.json in the subfolder.
STEP 3: Configure debug.json to look like the following. Replace "storyName_level" with your story name and level identical to the subfolder created earlier.
STEP 4: Configure config.json to include the following variable:
STEP 5: Launch RoboTutor.
@JackMostow - So far, everything about this seems to work, aside from recognition issues. I am not sure if this is device specific. Does creating this PR create an apk that you can test? If not, I'll send you one that I generate.