Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Powershell activation scripts for ROS2 #34

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Apr 18, 2022

@Tobias-Fischer
Copy link
Contributor Author

Hi @traversaro - I have blindly written the activate/deactivate ps1 scripts. Is there any chance you could give them a go? If they work I can trigger a rebuild of the ros-workspace package in the Galactic repo so that they are built and installed correctly.

@wolfv @traversaro - I have also no idea how the ps1.in scripts are converted to "pure" .ps1 scripts and whether I am missing some line prefixes in the ps1.in files so that the conversion happens correctly. (I modified the python scripts to trigger the conversion but didn't dig how it actually happens).

@traversaro
Copy link
Member

Is there any chance you could give them a go?

Just to understand, you mean use vinca to generate the recipes, build them via boa and then test them, right?

@Tobias-Fischer
Copy link
Contributor Author

I think to start with it would be sufficient to just call the (de-)activate scripts from a Powershell (i.e. copy the contents in a file somewhere) and see whether they 1) run without errors, and 2) set the intended environment variables and enable ROS2 to run. Once we have confirmed this, I can produce new packages and we can see whether the automated activation works too.

@Tobias-Fischer
Copy link
Contributor Author

Hey @traversaro @wolfv - did you have a chance to look at this?

@Tobias-Fischer Tobias-Fischer changed the title [WIP] Powershell activation scripts for Galactic [WIP] Powershell activation scripts for ROS2 Jan 13, 2023
@Tobias-Fischer
Copy link
Contributor Author

Kind ping @traversaro @wolfv

@traversaro
Copy link
Member

I think to start with it would be sufficient to just call the (de-)activate scripts from a Powershell (i.e. copy the contents in a file somewhere) and see whether they 1) run without errors, and 2) set the intended environment variables and enable ROS2 to run. Once we have confirmed this, I can produce new packages and we can see whether the automated activation works too.

I did this (by commenting the local_setup.ps1 inclusion), and the variables are indeed set by activate.ps1 and unset by deactivate.ps1 .

@Tobias-Fischer Tobias-Fischer merged commit 3b26d3f into master Jan 25, 2023
@Tobias-Fischer
Copy link
Contributor Author

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create activate scripts for PowerShell
2 participants