-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify all SharpFont projects into a single Portable library. #101
Conversation
…s. This checkin removes the name "__Internal" for IOS.
…roject. This results in only portable code in SharpFont. As a result, the SharpFont project is eliminated in favor of SharpFont.Portable.
…lete the SharpFont.Shared project.
This looks good except for the removal of the System.Drawing code for reasons I mentioned in Robmaister/SharpFont.HarfBuzz#9. If you look through some of the old issues you'll see several related to this one function, and I've received a few emails from people looking for help. ToGdipBitmap adds a lot of convenience and seems to be the go-to for people just starting out with the library. On the other hand, System.Drawing is disappearing with dotnet core, might be better to push off to a separate dll for System.Drawing functionality. The iOS/macOS fixes are excellent though! I'll mull over what I want to do with System.Drawing and get back to you shortly, and take a look at what dotnet core is looking to do with Bitmap. |
Also: my plan is to do away with the SharpFont.iOS and SharpFont.Portable nuget packages and make SharpFont the PCL version in this case, so if you could also move everything into SharpFont instead of SharpFont.Portable, that would be ideal 👍 |
The System.Drawing code has not been expunged. Instead it has been (carefully) extracted into an extension class,
This pull request is a step in the same direction. All that is left is for the SharpFont.Portable project to be renamed SharpFont, and for the nuspec to include the PCL as well as the platform-specific native assemblies in the appropriate folders. (I'm not a nuget expert so did not attempt this.) Cheers |
Done. [Please see my note above about |
…nuspec and SharpFont.iOS.nuspec. 2. Cleanup SharpFont.csproj: a) Remove SHARPFONT_PORTABLE b) Change the output path to SharpFont instead of SharpFont\Portable.
…es this project as a standard Portable Class Library and adds (Portable) to the display name in Solution Explorer.
Hi, are you planning to pull this PR? Be good to get into a regular sync schedule and pick up the pace. Let me know what works for you. Cheers, |
Yup, pulling this in now and going to run through some changes in issues right now |
This unifies all the projects into the existing SharpFont.Portable project, and eliminates SharpFont, SharpFont.iOS, and SharpFont.Shared.
Notes:
FTBitmapEx
in the Examples project. TODO: Perhaps this can be moved into a non-portable utility nuget if so desired.dllmap
entry for iOS toSharpFont.dll.config
.