Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove url field #556

Merged
merged 15 commits into from
Nov 25, 2024
Merged

remove url field #556

merged 15 commits into from
Nov 25, 2024

Conversation

DawoodMehmood
Copy link
Collaborator

Pull Request Template

Before submitting this PR, please make sure you have completed the following checklist. This helps ensure that our codebase remains high quality and that our features work well across all supported devices and themes.

Code Review

  • I have carefully reviewed my code and believe it is final from my side.
  • I have ensured there is no hardcoded color in my changes. Colors should be defined in theme files and reused.

Theme Compatibility

  • I have tested the new feature or updates in both light and dark themes.
  • I confirm that the visual aspects of the feature are compatible and appealing in both themes.

Device Compatibility

  • I have tested my changes on mobile screen sizes.
  • I have tested my changes on tablet screen sizes.
  • I have tested my changes on laptop screen sizes.

Functional Testing

  • I have thoroughly tested the functionality of my changes.
  • I am confident that my changes do not negatively impact existing features.

Testing Documentation

Please provide a brief description of the tests you have performed to verify your changes. Include any relevant scenarios or edge cases.

  • Example test 1: Tested feature X by uploading the image
  • Example test 2: Tested feature X by doing these things.

Demo Video

Please provide a demo video of your changes. This helps reviewers understand the changes and verify the functionality.

You can record the video using tools like Loom(https://www.loom.com/), Clip by ClickUp(https://clickup.com/features/clips), Sendspark(https://www.sendspark.com/), etc.

Include the link to the video below and make sure the video covers

  • Explain the task/bug you are solving
  • Show the changes in the UI
  • Show the changes in the codebase
  • Show the changes you tested to make sure it works
  • Show the changes in various screen sizes
  • Show the changes in both light and dark themes

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dodao-ui-academy-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 2:44pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dodao-ui-base-ui ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 2:44pm
dodao-ui-rubrics-ui ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 2:44pm

@@ -0,0 +1,5 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the placeholder images we are using for image and video were getting used fine but i was getting module not found on their imports. so i created this. i saw it in the academy-ui as well so i thought its missing from core

@RobinNagpal RobinNagpal merged commit 2279ca4 into main Nov 25, 2024
8 checks passed
@RobinNagpal RobinNagpal deleted the dawood/remove-url-field branch November 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants