-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove url field #556
remove url field #556
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
@@ -0,0 +1,5 @@ | |||
/// <reference types="next" /> | |||
/// <reference types="next/image-types/global" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the placeholder images we are using for image and video were getting used fine but i was getting module not found on their imports. so i created this. i saw it in the academy-ui as well so i thought its missing from core
Pull Request Template
Before submitting this PR, please make sure you have completed the following checklist. This helps ensure that our codebase remains high quality and that our features work well across all supported devices and themes.
Code Review
Theme Compatibility
Device Compatibility
Functional Testing
Testing Documentation
Please provide a brief description of the tests you have performed to verify your changes. Include any relevant scenarios or edge cases.
Demo Video
Please provide a demo video of your changes. This helps reviewers understand the changes and verify the functionality.
You can record the video using tools like Loom(https://www.loom.com/), Clip by ClickUp(https://clickup.com/features/clips), Sendspark(https://www.sendspark.com/), etc.
Include the link to the video below and make sure the video covers