Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to the server selection on error. #31

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Dec 14, 2015

This partially handles #22 by at the very least redirecting to the server selection screen. This is the simplest option until we put a real server selection in (which I'm about to do now).

/cc @luckydonald

rgbkrk added a commit that referenced this pull request Dec 14, 2015
Redirect to the server selection on error.
@rgbkrk rgbkrk merged commit 6c53d79 into RobCoIndustries:master Dec 14, 2015
@rgbkrk rgbkrk deleted the handle-socket-errors branch December 14, 2015 02:00
@rgbkrk
Copy link
Member Author

rgbkrk commented Dec 14, 2015

I've got the server selection in a clean setup, though it necessitates me finishing more of my redux learnings.

We'll basically have these state transitions:

  • Discovery
  • Server Selection
  • Connecting to the (TCP) Server
  • Full blown PipBoy

@luckydonald
Copy link
Member

This barely handles the issues of #22, feels more like #23 to me?

@luckydonald luckydonald mentioned this pull request Dec 14, 2015
5 tasks
@rgbkrk
Copy link
Member Author

rgbkrk commented Dec 14, 2015

I'll just toss my issue links there since I really just wanted to lay out the views and link to the relevant associated issues. Your checklist is nice, thanks for updating #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants