Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use >= instead of > for art_node*_prev_child #548

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Use >= instead of > for art_node*_prev_child #548

merged 1 commit into from
Jan 13, 2024

Conversation

SLieve
Copy link
Contributor

@SLieve SLieve commented Jan 13, 2024

Using > caused it to skip the first child. Only applies to node48 and node256 Modified an existing test to cover this case.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2024
View reviewed changes
tests/art_unit.cpp Fixed Show fixed Hide fixed
tests/art_unit.cpp Fixed Show fixed Hide fixed
@SLieve
Use >= instead of > for art_node*_prev_child
1589e6d 
Using > caused it to skip the first child. Modified an existing test to cover
this case.
Dr-Emann
Dr-Emann approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@Dr-Emann Dr-Emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@lemire lemire merged commit 19e6003 into RoaringBitmap:master Jan 13, 2024
25 checks passed
@SLieve SLieve deleted the art_prev branch January 22, 2024 21:07
@BrewTestBot BrewTestBot mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Emann Dr-Emann Dr-Emann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SLieve @Dr-Emann @lemire