Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singular Post - Pane Model #466

Merged
merged 11 commits into from
May 19, 2024
Merged

Singular Post - Pane Model #466

merged 11 commits into from
May 19, 2024

Conversation

KAMKEEL
Copy link
Collaborator

@KAMKEEL KAMKEEL commented May 19, 2024

MixinPane

Adds a new if statement that essentially cancels the rest of the bounding box and collisions functions - IF the pane is not connected to any other valid blocks.

Basically only needed for posts

MixinRenderBlocks

Modifies only the Pane and StainedGlassPane Render functions
Adds a new if statement that essentially cancels the rest of the render - IF the pane is not connected to any other valid blocks.

  • Pane Rendering

The Pane Rendering Y level needs to be - .001 below the top of the block so texture clipping doesn't occur or .001 above the lower bound of the block. This is accurate with 1.12s top and bottom for Iron Bars. Panes are also + PLUS shaped as opposed to a box.

  • Glass Pane Rendering

Minecraft hides the lower and upper faces of a glass pane if it rests on a block. But shows it if its connected to another panel Top-to-Bottom

1.12

2024-05-18_22 12 08

1.7.10 Backport

2024-05-18_22 13 22

@KAMKEEL KAMKEEL requested a review from Roadhog360 May 19, 2024 02:07
@Roadhog360
Copy link
Owner

Some suggestions for what the config option could be called:

  • thinPanes
  • narrowPanes

@Roadhog360 Roadhog360 merged commit 1b904a1 into Roadhog360:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants