Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add raw ores to ticon smeltery #437

Merged

Conversation

Pilzinsel64
Copy link

@Pilzinsel64 Pilzinsel64 commented Mar 14, 2024

Adds all registred raw ores to the smeltery as last step on postInit. It tries to find a block via the ore dictionary to get the required informations for registration (like temperature and output).

As block to render it uses "air". The Smeltery then seems to search for a massive block from the output material (like an iron block) to display. This is fine I guess.

  • An alternative would be to use the block we use to get temperature and fluid from the smeltery but this may confuse people if they smelt a raw ore and see a ore from Immersive Engeneering for example.
  • Another alternative (and the better one) would be to use a raw ore block. But for this I don't know a easy way to get that via our mapping here. Feel free to tweak that or give me a hint how to.

As project dependency I used GTNH-TiCon, but that shouldn't matter at all at runtime. I was not able to use the CurseForge builds at all for some reason.

grafik
grafik

@Roadhog360 Roadhog360 merged commit a0a6b85 into Roadhog360:master Mar 14, 2024
1 check passed
@Roadhog360
Copy link
Owner

Nice.

@Roadhog360
Copy link
Owner

I like the way you handled this, it's seemingly future-proof, and only registers what is needed, all in one fell swoop. Nicely done.

@Pilzinsel64 Pilzinsel64 deleted the feat/raw-ores-in-smeltery branch March 14, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants