how ? #294
how ? #294
Conversation
|
Uhm what exactly are you doing there? You did not even bother writing anything about the Pull Request you posted, this looks like you are just trying to farm repositories for street cred or something stupid like that. |
|
The code looks a little odd but is written the way it is for a reason. The variables are checked that way so the sounds do not repeatedly play, and only play once at a time, when the variable is flipped. I tested your commit and it causes a bug with repeatedly playing the deactivate sound when I create a beacon, which is the exact result I expected when reading your code... Did you even test this? I would like to ask what you're even trying to do but Perhaps my code could be better, I admit. But please be sure to test your code before creating a PR :) |
|
at last, I truly see |
verified by github web editor