Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Ulrich,
Playing with
ripser
using datasets where data was pruned using in my casecollapser
, I encountered an unexpected behaviour when reading distance matrices whereinf
values are present in the input file.std::istream
orstd::istringstream
returns 0 instead ofinf
if they encounterINF, Inf, etc.
in an input file when you try to directly assign the stream into afloat
ordouble
variable.Why are
inf
values in this distances matrices ? Because, when pruning data from the original distances matrices, I replace a pruned data byinf
.In attachment you'll find a distance matrix not pruned
dense.txt
. Its pruned versiondense_pruned.txt
and the lower and upper part of thedense_pruned.txt
to test the lower and upper reader.Command to test the different datasets:
The expected results is:
Please, feel free to suggest any modifications or if you have any remarks.
Best,
Julián