This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Add CMake for C #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the commonly used distro-wide (Windows and Linux/Mac) CMake build system. This should take care of the fact that you get linker errors just blankly compiling wiino.cpp. This will fix that along with having an install option and if we wanted to, even make a library for pkgconfig using the header files we have (story for another time?)
I also would've done something for Go (maybe setup a go.mod?) and Python (by using python3-setuptools) but both don't work, they don't have a main function so I'll come back to them. I also added a .gitignore and will eventually when all three languages are fixed up and all update the README. Lmk if there is anything wrong, the versions are based off of the oldest current supported Ubuntu cmake version of Bionic Beaver (3.10), which should be old enough for most Windows systems to have it.
I'm a dev who uses linux and my profile README should explain me basically. I want to contribute to RC24 I just don't know how so I hope here is a start.