Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use url encoding on part id #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mfaizudd
Copy link

@mfaizudd mfaizudd commented Aug 14, 2023

Recently, I've been trying to create an SDF file from an Onshape document, but it fails and tells me that some URL returns a 404 error. It turns out that this happens because the part ID contains a plus (+) character. I also came across issue #46 which fixes the unescaped slash problem. However, part IDs can also contain plus signs and possibly other characters. Therefore, I believe it would be best to URL encode the entire part ID. I also changed the function name since it no longer just escapes the slash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants