Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify intent extension API to parse redemption links to mimick iOS #1949

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tonidero
Copy link
Contributor

Description

This modifies the Intent.parseAsWebPurchaseRedemption() method to Intent.asWebPurchaseRedemption following the naming of the API in the iOS SDK, so we consolidate them. This is a breaking change but this is an experimental API not open to developers yet so it should be safe.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (50a3a78) to head (b53819c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...otlin/com/revenuecat/purchases/IntentExtensions.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1949   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files         260      260           
  Lines        8493     8493           
  Branches     1226     1226           
=======================================
  Hits         6954     6954           
  Misses       1041     1041           
  Partials      498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero marked this pull request as ready for review November 29, 2024 13:37
@tonidero tonidero requested review from a team November 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant