Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes artifact consolidation #1794

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes artifact consolidation #1794

wants to merge 1 commit into from

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Jul 25, 2024

As the title says. I noticed artifacts were not being uploaded to CircleCI.

However

Do we even want this? It's a lot. I already excluded paparrazi. We can also exclude kover maybe because we have codecov. That would still be quite a lot though.

I guess the main problem is that CircleCI shows it as a flat list of files instead of as a directory structure. See all artifacts for the tests in this PR here.

@JayShortway JayShortway self-assigned this Jul 25, 2024
@JayShortway JayShortway added the ci label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (46ed53d) to head (f1493c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1794   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files         223      223           
  Lines        7673     7673           
  Branches     1078     1078           
=======================================
  Hits         6359     6359           
  Misses        893      893           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants