Refactor options screen #1554
Merged
Refactor options screen #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be great to have an interface option (left of zurück) where some interface options are (like showgameframe info) :) |
|
perhaps we should even split out a "Network" category? and put the network stuff there? |
|
Makes sense. Maybe open an issue for that so someone with the time for it can do that :) Would be an easy task for first-time contributors I guess. |
1 task
Allow for easier extending by using relative values
Flamefire
force-pushed
the
refactor_options
branch
from
c564588
to
160885f
Compare
Flow86
approved these changes
Jul 16, 2023
|
@Flow86 The required check "Linux (clang, macos-12, Debug)" needs to be changed to "Linux (clang, macos-12, Debug, 1.82.0)" And what is the issue on Jenkins? Can't login right now to check. |
|
Oh I thought this one was already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1553
I needed some more space and a way to ease adding a new option.
New:
