-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some search functionality #1406
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// Place all the styles related to the search controller here. | ||
// They will automatically be included in application.css. | ||
// You can use Sass (SCSS) here: https://sass-lang.com/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
class SearchController < ApplicationController | ||
Check notice on line 1 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L1 <Style/FrozenStringLiteralComment>
Raw output
|
||
def index | ||
@results = [] | ||
@query = params[:q] | ||
return if @query.blank? | ||
|
||
@results = if params[:multi_search] == "1" | ||
multi_search_experiment | ||
else | ||
[*Answer.search(@query), *Question.search(@query)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doesn't take too long tbh (~2.7m documents)
|
||
end | ||
end | ||
|
||
private | ||
|
||
def multi_search_experiment | ||
MeiliSearch::Rails.client.multi_search( | ||
[Answer, Question].map do |klass| | ||
{ | ||
q: @query, | ||
index_uid: klass.name.to_s, | ||
show_ranking_score: true, | ||
} | ||
end | ||
Check notice on line 24 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L24 <Style/TrailingCommaInArguments>
Raw output
|
||
)["results"].flat_map do |h| | ||
model = h["indexUid"].constantize # bad practice! | ||
results = model.find(h["hits"].pluck("id")).map { |r| [r.id.to_s, r] }.to_h | ||
Check notice on line 27 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L27 <Rails/IndexBy>
Raw output
Check notice on line 27 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L27 <Style/MapToHash>
Raw output
|
||
h["hits"].map { |hit| [hit["_rankingScore"], results[hit["id"]]] } | ||
end | ||
.sort_by(&:first) | ||
.reverse | ||
.tap { |results| Rails.logger.debug(results) } | ||
Check notice on line 32 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L29-L32 <Style/MultilineBlockChain>
Raw output
|
||
.map(&:last) | ||
Check notice on line 33 in app/controllers/search_controller.rb GitHub Actions / rubocop[rubocop] app/controllers/search_controller.rb#L33 <Layout/MultilineMethodCallIndentation>
Raw output
|
||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
module SearchHelper | ||
Check notice on line 1 in app/helpers/search_helper.rb GitHub Actions / rubocop[rubocop] app/helpers/search_helper.rb#L1 <Style/FrozenStringLiteralComment>
Raw output
|
||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.container-lg.container--main | ||
.row | ||
.col-sm-10.col-md-10.col-lg-9.mx-auto | ||
.card | ||
.card-body | ||
= bootstrap_form_with url: search_path, layout: :inline, method: :get do |f| | ||
= f.text_field :q, skip_label: true, append: f.primary("Search"), value: params[:q] | ||
= f.check_box :multi_search, label: "Multisearch" | ||
- unless @results.blank? | ||
.container-lg.container--main | ||
.row | ||
.col-sm-10.col-md-10.col-lg-9.mx-auto | ||
- @results.each do |result| | ||
- case result | ||
- when Answer | ||
= render "answerbox", a: result, display_all: false, subscribed_answer_ids: [] | ||
- when Question | ||
= render "shared/question", q: result, type: nil | ||
|
||
= render 'shared/links' | ||
|
||
:ruby | ||
provide(:title, generate_title('Search')) | ||
parent_layout 'base' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# frozen_string_literal: true | ||
|
||
return unless ENV["SEARCH_ENABLED"] == "true" | ||
|
||
MeiliSearch::Rails.configuration = { | ||
meilisearch_url: ENV.fetch("MEILISEARCH_HOST", "http://localhost:7700"), | ||
meilisearch_api_key: ENV.fetch("MEILISEARCH_API_KEY", "justfordev42069e621") | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
require 'rails_helper' | ||
Check notice on line 1 in spec/helpers/search_helper_spec.rb GitHub Actions / rubocop[rubocop] spec/helpers/search_helper_spec.rb#L1 <Style/FrozenStringLiteralComment>
Raw output
Check notice on line 1 in spec/helpers/search_helper_spec.rb GitHub Actions / rubocop[rubocop] spec/helpers/search_helper_spec.rb#L1 <Style/StringLiterals>
Raw output
|
||
|
||
# Specs in this file have access to a helper object that includes | ||
# the SearchHelper. For example: | ||
# | ||
# describe SearchHelper do | ||
# describe "string concat" do | ||
# it "concats two strings with spaces" do | ||
# expect(helper.concat_strings("this","that")).to eq("this that") | ||
# end | ||
# end | ||
# end | ||
RSpec.describe SearchHelper, type: :helper do | ||
pending "add some examples to (or delete) #{__FILE__}" | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
require 'rails_helper' | ||
Check notice on line 1 in spec/requests/search_spec.rb GitHub Actions / rubocop[rubocop] spec/requests/search_spec.rb#L1 <Style/FrozenStringLiteralComment>
Raw output
Check notice on line 1 in spec/requests/search_spec.rb GitHub Actions / rubocop[rubocop] spec/requests/search_spec.rb#L1 <Style/StringLiterals>
Raw output
|
||
|
||
RSpec.describe "Searches", type: :request do | ||
describe "GET /index" do | ||
it "returns http success" do | ||
get "/search/index" | ||
expect(response).to have_http_status(:success) | ||
end | ||
end | ||
|
||
end | ||
Check notice on line 11 in spec/requests/search_spec.rb GitHub Actions / rubocop[rubocop] spec/requests/search_spec.rb#L10-L11 <Layout/EmptyLinesAroundBlockBody>
Raw output
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
require 'rails_helper' | ||
Check notice on line 1 in spec/views/search/index.html.erb_spec.rb GitHub Actions / rubocop[rubocop] spec/views/search/index.html.erb_spec.rb#L1 <Style/FrozenStringLiteralComment>
Raw output
Check notice on line 1 in spec/views/search/index.html.erb_spec.rb GitHub Actions / rubocop[rubocop] spec/views/search/index.html.erb_spec.rb#L1 <Style/StringLiterals>
Raw output
|
||
|
||
RSpec.describe "search/index.html.erb", type: :view do | ||
pending "add some examples to (or delete) #{__FILE__}" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's the same thing (~2.7m documents), but combined in the same request: