Add Pointer Inspector dialog #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is incomplete
At this time, the dialog is just a viewer, and the Add Bookmark button doesn't work. That will be added in a future PR, along with the ability to edit notes and add new fields.
These examples are from GBA, where the conversion from real address to RA address is mask to 24 bit and add 8000. The note has those baked in by specifying a 24-bit pointer size and using +800X for offsets. On other systems where there's a mask applied, the logic added in #1114 will apply an appropriate mask when following the pointer chain.
Supports Pause on Change behavior
And shows invalid pointers in the chain (red is null, yellow is outside valid range)
The dropdown in the upper right allows the user to select the current node for viewing in the rest of the dialog.
While the format and behavior fields can be changed, those changes are not persisted in any way. Changing the root address or selected node and coming back will reset everything to Hex and not Pause on Change. That functionality may not even be needed after the Add Bookmark functionality is in place.
Changing the size field will be persisted (in a future PR) by updating the note.