attempt to gracefully return 429 errors when uploading assets #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1117
Modifies the upload APIs to return Incomplete instead of Failed when the server responds with a 429 error.
The upload dialog has been modified to handle the Incomplete return code by sleeping for a random period of time between 500 and 1500ms (to let the server recover a bit) and then retry the request. This will be repeated until the request clearly succeeds or fails.
This also affects a few other non-rcheevos APIs like friend activity, but as Incomplete is not a Success code, I believe they will still error out in the same manner as before.