Fix bug where modifying conditions improperly hide the target value cell. #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Jul 27, 2024
Jamiras
reviewed
Jul 28, 2024
Jamiras
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a modifying condition like Add Source, the Target Value will be hidden when you first change the operator away form 'None', until you change the Target Type. This was especially noticeable when pasting in something like Add Source Mem 0x1234 / Mem 0x1234, but also evident if you just created a new condition and immediately changed the flag to Add Source, followed by setting the operator.
OnValueChanged handler is updated to re-evaluate the HasTargetValuePropertly when the operator is changed.