Insert in TAIL and remove from HEAD off list

.rspec

@@ -1,3 +1,4 @@
 --format documentation
 --color
 --require spec_helper
+--order random

lib/upperkut/strategy.rb

@@ -14,7 +14,7 @@ def initialize(worker, redis)
  def push_items(items = [])
  items = [items] if items.is_a?(Hash)
  return false if items.empty?
- redis.lpush(key, encode_json_items(items))
+ redis.rpush(key, encode_json_items(items))
  end
 
  def fetch_items(batch_size = 1000)

spec/upperkut/strategy_spec.rb

@@ -17,11 +17,22 @@ class DummyWorker
  describe '.push_items' do
  it 'insert items in the queue' do
  expect do
- strategy.push_items(['event' => 'open'])
- end.to change { strategy.size }.from(0).to(1)
+ strategy.push_items([{ 'event' => 'open' }, { 'event' => 'click' }])
+ end.to change { strategy.size }.from(0).to(2)
  end
 
- context 'when items isnt a array' do
+ it 'insert items in the tail' do
+ strategy.push_items([{ 'event' => 'open' }])
+ strategy.push_items('event' => 'click')
+
+ items = strategy.fetch_items.collect do |item|
+ item['body']
+ end
+
+ expect(items.last).to eq('event' => 'click')
+ end
+
+ context 'when items isn\'t a array' do
  it 'inserts item in the queue' do
  expect do
  strategy.push_items('event' => 'open', 'k' => 1)
@@ -30,6 +41,18 @@ class DummyWorker
  end
  end
 
+ describe '.fetch_items' do
+ it 'returns the head items off queue' do
+ strategy.push_items([{ 'event' => 'open' }, { 'event' => 'click' }])
+
+ items = strategy.fetch_items.collect do |item|
+ item['body']
+ end
+
+ expect(items).to eq([{ 'event' => 'open' }, { 'event' => 'click' }])
+ end
+ end
+
  describe '.clear' do
  it 'deletes the queue' do
  strategy.push_items(['event' => 'open'])

spec/worker_spec.rb

@@ -31,6 +31,6 @@ class DummyWorker
  item['body']
  end
 
- expect(items_saved).to match_array(items)
+ expect(items_saved).to eq(items)
  end
 end