Fix bug when Multiple
is passed an invalid value
#1467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using
Multiple
to validate, and pass a value that is unsupported by the%
operator, it will fail instead of creating a validation error. This fixes that bug.Example of code the reproduces the bug:
I'm submitting against the 2.3 branch instead of main because that's the version I'm using, and the version I tested this change against. It looks like the library has undergone significant refactoring since 2.3, so this probably can't be merged as-is to main.
This uses the same method that was already in use in the
Even
rule. Probably a better way of doing things would be some kind of "short circuit" where, sinceintType
fails,multiple
is never used. But, I don't want to throw anything drastic your way since it looks like you're in the middle of a big refactor.