Skip to content

Commit

Permalink
Don't show "Important Notice" when RP is *disabled*
Browse files Browse the repository at this point in the history
  • Loading branch information
myrdd committed May 21, 2015
1 parent 4f98957 commit 206a4fa
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions src/components/requestpolicyService.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ RequestPolicyService.prototype = {
return;
}

if (addon.isActive === false) {
// RP is disabled
return;
}

const url = "chrome://rpcontinued/content/rp-and-rpc.html";

var wm = CC["@mozilla.org/appshell/window-mediator;1"]
Expand Down
4 changes: 2 additions & 2 deletions src/content/rp-and-rpc.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ <h1>Important Notice! <span>regarding RequestPolicy</span></h1>

<p>
However, currently both <i>&ldquo;RequestPolicy&rdquo;</i> and
<i>&ldquo;RequestPolicy Continued&rdquo;</i> are installed in your browser.
<b>This will lead to conflicts!</b>
<i>&ldquo;RequestPolicy Continued&rdquo;</i> are installed and enabled
in your browser. <b>This will lead to conflicts!</b>
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion src/install.rdf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<Description about="urn:mozilla:install-manifest">
<em:name>RequestPolicy Continued</em:name>
<em:version>0.5.29b3</em:version>
<em:version>0.5.29b4</em:version>
<em:type>2</em:type>
<em:description>Control which cross-site requests are allowed. Improve the privacy of your browsing. Secure yourself from Cross-Site Request Forgery (CSRF) and other attacks.</em:description>
<em:id>[email protected]</em:id>
Expand Down

0 comments on commit 206a4fa

Please sign in to comment.