-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: make Simple_Prep_docker run on OSX #19
Conversation
…ling \ for bash -c invocation
@satra -- I have no working docker on OSX, so could just verify that it seems to generate correct Dockerfile and then verify that it works on Linux. Could you give it a shot on OSX following current(modified) README.md |
will do - also added list of things to take care of today - #20. |
on osx:
let me first update docker file before you make anymore changes. |
Are you sure you are in my branch? Check on invocation in readme - needs release and a date |
ah no. i was blindly using master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a minor revert for cleanness
Simple_Prep_docker
Outdated
echo "sed -i -e 's,http://neuro.debian.net/debian/* ,http://snapshot-neuro.debian.net:5002/archive/neurodebian/$DL_DATE/ ,g' etc/apt/sources.list.d/neurodebian.sources.list;" | ||
# replace with snapshots. Cannot use -i due to OSX but since done inside the container | ||
# should be safe just to use some explicit /tmp/apt.sources | ||
echo "sed -e 's,http://neuro.debian.net/debian/* ,http://snapshot-neuro.debian.net:5002/archive/neurodebian/$DL_DATE/ ,g' etc/apt/sources.list.d/neurodebian.sources.list > /tmp/apt.sources; mv /tmp/apt.sources etc/apt/sources.list.d/neurodebian.sources.list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this change is not needed... I was blinded by the osx pain :-)
pushed that little revert... @satra -- could you check if all is kosher on OSX so it could finally be merged/forgotten about? ;) |
works on my OSX version: 10.12.4 (16E195) |
as @khinsen pointed out -- dockerfile preparation script doesn't work on OSX . This is a PR to address that
Closes #17
Relates to #15