Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: make Simple_Prep_docker run on OSX #19

Merged
merged 4 commits into from
Apr 7, 2017
Merged

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Apr 5, 2017

as @khinsen pointed out -- dockerfile preparation script doesn't work on OSX . This is a PR to address that

  • no sed -i and readlink -f
  • check if it works and fix the rest of OSX compatibility issues
  • double check back on Linux systems that it works as expected

Closes #17
Relates to #15

@yarikoptic yarikoptic self-assigned this Apr 5, 2017
@yarikoptic
Copy link
Member Author

@satra -- I have no working docker on OSX, so could just verify that it seems to generate correct Dockerfile and then verify that it works on Linux. Could you give it a shot on OSX following current(modified) README.md

@satra
Copy link
Collaborator

satra commented Apr 5, 2017

will do - also added list of things to take care of today - #20.

@satra
Copy link
Collaborator

satra commented Apr 5, 2017

on osx:

$ ./Simple_Prep_docker Simple_Prep_docker-Dockerfile.in 
readlink: illegal option -- f
usage: readlink [-n] [file ...]

let me first update docker file before you make anymore changes.

@yarikoptic
Copy link
Member Author

Are you sure you are in my branch? Check on invocation in readme - needs release and a date

@satra
Copy link
Collaborator

satra commented Apr 5, 2017

ah no. i was blindly using master.

Copy link
Member Author

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a minor revert for cleanness

echo "sed -i -e 's,http://neuro.debian.net/debian/* ,http://snapshot-neuro.debian.net:5002/archive/neurodebian/$DL_DATE/ ,g' etc/apt/sources.list.d/neurodebian.sources.list;"
# replace with snapshots. Cannot use -i due to OSX but since done inside the container
# should be safe just to use some explicit /tmp/apt.sources
echo "sed -e 's,http://neuro.debian.net/debian/* ,http://snapshot-neuro.debian.net:5002/archive/neurodebian/$DL_DATE/ ,g' etc/apt/sources.list.d/neurodebian.sources.list > /tmp/apt.sources; mv /tmp/apt.sources etc/apt/sources.list.d/neurodebian.sources.list"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this change is not needed... I was blinded by the osx pain :-)

@yarikoptic
Copy link
Member Author

pushed that little revert... @satra -- could you check if all is kosher on OSX so it could finally be merged/forgotten about? ;)

@satra
Copy link
Collaborator

satra commented Apr 7, 2017

works on my OSX version: 10.12.4 (16E195)

@satra satra merged commit 1d57861 into ReproNim:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple_Prep_docker not running on MacOS 10.12.3 (Sierra) ?
2 participants