Tune up time/timing/logs in reprostim-videocapture and QR parsing #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Jul 10, 2024
Parsing/parse_wQR.py
Outdated
Comment on lines
50
to
52
| return (f"QrRecord(frames=[{self.frame_start}, {self.frame_end}], " | ||
| f"pos=[{self.start_pos_sec}, {self.end_pos_sec} sec], " | ||
| f"start_time={self.start_time}, end_time={self.end_time}], " |
There was a problem hiding this comment.
Let's uniformize
Suggested change
| return (f"QrRecord(frames=[{self.frame_start}, {self.frame_end}], " | |
| f"pos=[{self.start_pos_sec}, {self.end_pos_sec} sec], " | |
| f"start_time={self.start_time}, end_time={self.end_time}], " | |
| return (f"QrRecord(frames=[{self.frame_start}, {self.frame_end}], " | |
| f"times=[{self.start_pos_sec}, {self.end_pos_sec} sec], " | |
| f"abs_times=[{self.start_time}, {self.end_time}], " |
and make it a json single line record
yarikoptic
reviewed
Jul 10, 2024
Parsing/parse_wQR.py
Outdated
| logger.error(f"Path does not exist: {path}") | ||
| return 1 | ||
|
|
||
| do_parse(path) |
There was a problem hiding this comment.
direct logs to stderr.
could this function yield those records as soon as figures out, and here have a loop
Suggested change
| do_parse(path) | |
| for rec in do_parse(path): | |
| print(rec.model_dump_json()) |
this way we could use do_parse programmatically later on if needed without going back and forth through json
yarikoptic
reviewed
Jul 10, 2024
Parsing/parse_wQR.py
Outdated
| end_time: Optional[str] = Field(None, description="Time where QR code ends") | ||
| start_pos_sec: Optional[float] = Field(None, description="Position in seconds " | ||
| "where QR code starts") | ||
| end_pos_sec: Optional[float] = Field(None, description="Position in seconds " |
There was a problem hiding this comment.
let's uniformize into
❯ echo {frame,time,isotime}_{start,end}
frame_start frame_end time_start time_end isotime_start isotime_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aggregated PR. Closes #99 . Closes #100 . Closes #98.