Skip to content

Commit

Permalink
run precommit
Browse files Browse the repository at this point in the history
  • Loading branch information
Remi-Gau committed Aug 15, 2024
1 parent 6887052 commit 6d76eb5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
11 changes: 7 additions & 4 deletions neurodocker/cli/tests/test_build_images_with_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# TODO: make it work -- seems has difficulty installing jq,
# may be curl isn't there or alike
# ("portage", "gentoo"),
],
],
)
def test_build_image_from_registered(
tmp_path: Path, cmd: str, pkg_manager: str, base_image: str
Expand Down Expand Up @@ -133,9 +133,12 @@ def test_gentoo_image(tmp_path: Path):
generate,
[
cmd,
"--pkg-manager", "portage",
"--base-image", "gentoo",
"--install", "app-misc/mime-types",
"--pkg-manager",
"portage",
"--base-image",
"gentoo",
"--install",
"app-misc/mime-types",
],
)
assert result.exit_code == 0, result.output
Expand Down
2 changes: 1 addition & 1 deletion neurodocker/reproenv/renderers.py
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ def from_(self, base_image: str, as_: str = None) -> DockerRenderer:
# TODO: figure out hashes for the date
# s += "ARG gentoo_hash=2d25617a1d085316761b06c17a93ec972f172fc6\n"
# s += "ARG science_hash=73916dd3680ffd92e5bd3d32b262e5d78c86a448\n"
s += "ARG FEATURES=\"-ipc-sandbox -network-sandbox -pid-sandbox\"\n"
s += 'ARG FEATURES="-ipc-sandbox -network-sandbox -pid-sandbox"\n'
else:
if as_ is None:
s = "FROM " + base_image
Expand Down
4 changes: 2 additions & 2 deletions neurodocker/templates/gentoo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ binaries:
something: not-used
arguments:
optional:
gentoo_hash: "282c4b518562e6c194761d9ce0882f30672219c5"
science_hash: "e4579f5851734f245b02cc1e98f3b69d9df67e09"
gentoo_hash: 282c4b518562e6c194761d9ce0882f30672219c5
science_hash: e4579f5851734f245b02cc1e98f3b69d9df67e09
# Below echo commands will be indented by _indent_run_instruction which
# would cause trailing spaces to be added to the files. But it should be ok
# for us, thus we are not bothering to workaround via inlining.
Expand Down

0 comments on commit 6d76eb5

Please sign in to comment.