Fix key error when notification returns empty list.

RenierM26 · Aug 11, 2022 · 91b177f · 91b177f
1 parent 53d54d9
commit 91b177f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/pyhyypapi/alarm_info.py b/pyhyypapi/alarm_info.py
@@ -31,15 +31,17 @@ def _last_notice(self, site_id: int) -> dict[Any, Any]:
             site_id=site_id, json_key=0
         )
 
-        _last_event = _last_notification["eventNumber"]
-        _last_event_datetime = str(
-            datetime.fromtimestamp(_last_notification["timestamp"] / 1000)
-        )  # Epoch in ms
-
-        _response = {
-            "lastNoticeTime": _last_event_datetime,
-            "lastNoticeName": EventNumber[str(_last_event)],
-        }
+        if _last_notification:
+
+            _last_event = _last_notification["eventNumber"]
+            _last_event_datetime = str(
+                datetime.fromtimestamp(_last_notification["timestamp"] / 1000)
+            )  # Epoch in ms
+
+            _response = {
+                "lastNoticeTime": _last_event_datetime,
+                "lastNoticeName": EventNumber[str(_last_event)],
+            }
 
         return _response
 

diff --git a/pyhyypapi/client.py b/pyhyypapi/client.py
@@ -178,7 +178,7 @@ def site_notifications(
                 f"Error getting site notifications from api: {_json_result['error']}"
             )
 
-        if json_key is None:
+        if not json_key or _json_result["listSiteNotifications"][str(site_id)] is None:
             return _json_result["listSiteNotifications"][str(site_id)]
 
         return _json_result["listSiteNotifications"][str(site_id)][json_key]

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name='pyhyypapi',
-    version="0.0.0.5",
+    version="0.0.0.6",
     license='Apache Software License 2.0',
     author='Renier Moorcroft',
     author_email='[email protected]',