Feature/parameter requirements (GSA#1013)

* introduce parameter requirements Co-Authored-By: A.J. Stein <[email protected]> * add warning constraint for aggregate params + remove them * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Kylie Hunter <[email protected]> --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Kylie Hunter <[email protected]>
Rene2mt · Dec 20, 2024 · 95fc9a8 · 95fc9a8
1 parent 996ad29
commit 95fc9a8
Show file tree

Hide file tree

Showing 10 changed files with 11,642 additions and 9,334 deletions.
diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature
@@ -26,6 +26,7 @@ Examples:
 | constraint_id |
 #BEGIN_DYNAMIC_CONSTRAINT_IDS
   | address-type |
+  | aggregate-parameters-warning |
   | attachment-type |
   | authentication-method-has-remarks |
   | authorization-type |
@@ -92,6 +93,7 @@ Examples:
   | has-network-architecture-diagram-link-rel |
   | has-network-architecture-diagram-link-rel-allowed-value |
   | has-published-date |
+  | has-required-parameters |
   | has-rules-of-behavior |
   | has-security-impact-level |
   | has-security-sensitivity-level |
@@ -173,6 +175,8 @@ Examples:
 #BEGIN_DYNAMIC_TEST_CASES
   | address-type-FAIL.yaml |
   | address-type-PASS.yaml |
+  | aggregate-parameters-warning-FAIL.yaml |
+  | aggregate-parameters-warning-PASS.yaml |
   | attachment-type-FAIL.yaml |
   | attachment-type-PASS.yaml |
   | authentication-method-has-remarks-FAIL.yaml |
@@ -305,6 +309,8 @@ Examples:
   | has-network-architecture-diagram-link-rel-allowed-value-PASS.yaml |
   | has-published-date-FAIL.yaml |
   | has-published-date-PASS.yaml |
+  | has-required-parameters-FAIL.yaml |
+  | has-required-parameters-PASS.yaml |
   | has-rules-of-behavior-FAIL.yaml |
   | has-rules-of-behavior-PASS.yaml |
   | has-security-impact-level-FAIL.yaml |

diff --git a/features/steps/fedramp_extensions_steps.ts b/features/steps/fedramp_extensions_steps.ts
@@ -334,8 +334,11 @@ async function checkConstraints(
       );
       if (constraintResults.length === 0) {
         errors.push(
-          `Constraint rule not found: ${constraint_id}. The constraint may not be applicable to this content.`
+          `Constraint rule not found: ${constraint_id}. The constraint may not be applicable to this content, or there was a runtime error.`
         );
+        const sarifErrors=formatSarifOutput(sarifOutput)
+        !errors.includes(sarifErrors) && errors.push(sarifErrors)
+
         continue;
       }