Support for avatar decorations #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. |
|
Ah yes, the deserialization tests. Almost forgot. Thanks! |
MazeXP
reviewed
Dec 13, 2022
| /// <returns>A result which may or may not have succeeded.</returns> | ||
| public static Result<Uri> GetUserAvatarDecorationUrl | ||
| ( | ||
| IUser user, |
There was a problem hiding this comment.
IPartialUser might be better to use to also support those instances.
There was a problem hiding this comment.
It's IUser to be consistent with the other methods (such as GetUserBannerUrl below)
There was a problem hiding this comment.
In general I think IPartialUser should be used.
There was a problem hiding this comment.
I think that'd be better suited for its own PR to overhaul the entire CDN class. cc @Nihlus?
There was a problem hiding this comment.
I would say so aswell with its own PR then.
|
Any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discord/discord-api-docs#5723