-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite from Shirasu 1993 #286
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,13 +98,80 @@ | |
note="graphene MD data from table III", | ||
) | ||
|
||
import numpy as np | ||
|
||
graphite_density = 2.266 * u.g / u.cm**3 | ||
|
||
carbon_atomic_mass = 12.011 * u.g / u.mol | ||
|
||
graphite_atomic_density = graphite_density / carbon_atomic_mass | ||
|
||
shirasu_solubility_IG_110U = Solubility( | ||
S_0=np.exp(-14.5) * graphite_atomic_density * u.Pa**-0.5, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm dumb and does Pint bring units over in the calculation? Ideally you want units of H atoms * m^-3 * Pa^0.5. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything is converted to H atoms m^-3 Pa^-0.5 as long as you give it something with the same dimension. If by mistake you don't give it the right dimension, then an error will be raised. |
||
E_S=-18.2 * u.kJ / u.mol, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the incorrect value for activation energy. It should be the B value in Table 1 with units of K^-1. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The paper says that the enthalpy of solution ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I confirm that this is correct: B = 2190 * u.K
E = -htm.k_B * B
print(E.to(u.kJ / u.mol)) produces
Plus, |
||
source="shirasu_thermodynamic_1993", | ||
note="graphite IG-110U, data from Table 1", | ||
range=(u.Quantity(700, u.degC), u.Quantity(1000, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
shirasu_solubility_POCO_AXS_5Q = Solubility( | ||
S_0=np.exp(-15.6) * graphite_atomic_density * u.Pa**-0.5, | ||
E_S=-21.5 * u.kJ / u.mol, | ||
source="shirasu_thermodynamic_1993", | ||
note="graphite POCO AXS-5Q, data from Table 1", | ||
range=(u.Quantity(700, u.degC), u.Quantity(1000, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
shirasu_solubility_ISO_880U_low_temp = Solubility( | ||
S_0=np.exp(-15.8) * graphite_atomic_density * u.Pa**-0.5, | ||
E_S=-22.0 * u.kJ / u.mol, | ||
source="shirasu_thermodynamic_1993", | ||
note="graphite ISO-880U, data from Table 1", | ||
range=(u.Quantity(700, u.degC), u.Quantity(900, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
shirasu_solubility_ISO_880U_high_temp = Solubility( | ||
S_0=np.exp(-18.5) * graphite_atomic_density * u.Pa**-0.5, | ||
E_S=-48.2 * u.kJ / u.mol, | ||
source="shirasu_thermodynamic_1993", | ||
note="graphite ISO-880U, data from Table 1", | ||
range=(u.Quantity(900, u.degC), u.Quantity(1000, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
shirasu_solubility_EK_98_low_temp = Solubility( | ||
S_0=np.exp(-14.7) * graphite_atomic_density * u.Pa**-0.5, | ||
E_S=-13.5 * u.kJ / u.mol, | ||
source="shirasu_thermodynamic_1993", | ||
note="graphite EK-98, data from Table 1", | ||
range=(u.Quantity(700, u.degC), u.Quantity(800, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
shirasu_solubility_EK_98_high_temp = Solubility( | ||
S_0=np.exp(-18.5) * graphite_atomic_density * u.Pa**-0.5, | ||
E_S=-47.6 * u.kJ / u.mol, | ||
source="shirasu_thermodynamic_1993", | ||
note="graphite EK-98, data from Table 1", | ||
range=(u.Quantity(800, u.degC), u.Quantity(1000, u.degC)), | ||
isotope="H", | ||
) | ||
|
||
properties = [ | ||
causey_diffusivity, | ||
atsumi_diffusivity, | ||
atsumi_solubility, | ||
petucci_diffusivity_graphite, | ||
petucci_diffusivity_graphene, | ||
shirasu_solubility_IG_110U, | ||
shirasu_solubility_POCO_AXS_5Q, | ||
shirasu_solubility_ISO_880U_low_temp, | ||
shirasu_solubility_ISO_880U_high_temp, | ||
shirasu_solubility_EK_98_low_temp, | ||
shirasu_solubility_EK_98_high_temp, | ||
] | ||
|
||
for prop in properties: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need Avogadro's number in there to convert to atomic density.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is handled by pint automatically. Pint knows that 1 mol = 6.022e23 particles