-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added guthrie Mo data #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulbrrn thanks for your first contribution!
The main issue with this is that you haven't really added anything to the database.
If you try and run:
import h_transport_materials as htm
htm.permeabilities.filter(material=htm.MOLYBDENUM, author="guthrie")
It won't find anything.
Thats because you need to create a new property object and add it to the database.
I've added some details in the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be included in version control (see the second line in the file) please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you accidentally added this file to version control, please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you accidentally added this file to version control, please remove
guthrie_p_0 = 3.8e-3 * u.ccSTP * u.cm**-1 * u.s**-1 * u.atm**-0.5 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is the pre-exponential factor for deuterium's permeability in Mo (Figure 7 in the paper).
If you want to add this property to HTM then you need to:
- Create an
ArrheniusProperty
object (here usePermeability
) in h_transport_materials/property_database/molybdenum.py - Add it to the database as explained in the contributing guide
Here it would look something like:
guthrie_permeability = Permeability(
pre_exp=3.8e-3 * u.ccSTP * u.cm**-1 * u.s**-1 * u.atm**-0.5,
act_energy=17.4 * u.kcal * u.g**-1, # careful here with the conversion from kcal/g-atom to kcal/mol
range=(u.Quantity(270, u.degC), u.Quantity(640, u.degC)),
note="Figure 7",
source="Guthrie1974",
)
Added Mo permeation data and citation from Guthrie1974