Skip to content

Commit

Permalink
added notes for temperature range inconsistency
Browse files Browse the repository at this point in the history
  • Loading branch information
RemDelaporteMathurin committed Sep 7, 2023
1 parent c58b523 commit 20e0822
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
8 changes: 4 additions & 4 deletions h_transport_materials/property_database/niobium.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
u.Quantity(100, u.degC),
),
source="qi_tritium_1983",
note="table 1",
note="table 1, temperature range from Fig 1",
isotope="T",
)

Expand All @@ -31,7 +31,7 @@
u.Quantity(100, u.degC),
),
source="qi_tritium_1983",
note="table 1",
note="table 1, temperature range from Fig 1",
isotope="D",
)

Expand All @@ -43,7 +43,7 @@
u.Quantity(100, u.degC),
),
source="qi_tritium_1983",
note="table 1",
note="table 1, temperature range from Fig 1",
isotope="H",
)

Expand All @@ -55,7 +55,7 @@
250 * u.K,
),
source="qi_tritium_1983",
note="table 1",
note="table 1, temperature range from Fig 1",
isotope="H",
)

Expand Down
8 changes: 4 additions & 4 deletions h_transport_materials/property_database/tantalum.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
u.Quantity(-180, u.degC),
250 * u.K,
),
note="table 1",
note="table 1, temperature range from Fig 1",
source="qi_tritium_1983",
isotope="H",
)
Expand All @@ -39,7 +39,7 @@
250 * u.K,
u.Quantity(100, u.degC),
),
note="table 1",
note="table 1, temperature range from Fig 1",
source="qi_tritium_1983",
isotope="H",
)
Expand All @@ -51,7 +51,7 @@
u.Quantity(-140, u.degC),
u.Quantity(100, u.degC),
),
note="table 1",
note="table 1, temperature range from Fig 1",
source="qi_tritium_1983",
isotope="D",
)
Expand All @@ -63,7 +63,7 @@
u.Quantity(-140, u.degC),
u.Quantity(100, u.degC),
),
note="table 1",
note="table 1, temperature range from Fig 1",
source="qi_tritium_1983",
isotope="T",
)
Expand Down
3 changes: 3 additions & 0 deletions h_transport_materials/property_database/vanadium.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
u.Quantity(200, u.degC),
),
source="qi_tritium_1983",
note="table 1, temperature range from Fig 1",
isotope="H",
)

Expand All @@ -38,6 +39,7 @@
u.Quantity(200, u.degC),
),
source="qi_tritium_1983",
note="table 1, temperature range from Fig 1",
isotope="D",
)

Expand All @@ -49,6 +51,7 @@
u.Quantity(200, u.degC),
),
source="qi_tritium_1983",
note="table 1, temperature range from Fig 1",
isotope="T",
) # TODO get data from experimental points, see issue #64

Expand Down

0 comments on commit 20e0822

Please sign in to comment.