Skip to content

Commit

Permalink
Improve titles
Browse files Browse the repository at this point in the history
  • Loading branch information
Rem0o committed Jul 2, 2024
1 parent e7e3a6d commit f5d0c7b
Show file tree
Hide file tree
Showing 8 changed files with 5,035 additions and 5,436 deletions.
10,412 changes: 5,004 additions & 5,408 deletions package-lock.json

Large diffs are not rendered by default.

34 changes: 17 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,24 @@
"astro": "astro"
},
"devDependencies": {
"@astrojs/partytown": "^2.0.4",
"@astrojs/react": "^3.3.0",
"@astrojs/sitemap": "^3.1.3",
"@astrojs/partytown": "^2.1.1",
"@astrojs/react": "^3.6.0",
"@astrojs/sitemap": "^3.1.6",
"@astrojs/tailwind": "^5.1.0",
"@types/gtag.js": "^0.0.18",
"@types/react": "^18.2.79",
"@types/react-dom": "^18.2.25",
"astro": "^4.6.2",
"@types/gtag.js": "^0.0.20",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"astro": "^4.11.3",
"astro-robots-txt": "^1.0.0",
"postcss": "^8.4.38",
"prettier": "^3.2.5",
"prettier-plugin-astro": "^0.13.0",
"prettier-plugin-tailwindcss": "^0.5.14",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-intersection-observer": "^9.8.2",
"tailwind-merge": "^2.2.2",
"tailwindcss": "^3.4.3",
"typescript": "^5.4.5"
"postcss": "^8.4.39",
"prettier": "^3.3.2",
"prettier-plugin-astro": "^0.14.0",
"prettier-plugin-tailwindcss": "^0.6.5",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-intersection-observer": "^9.10.3",
"tailwind-merge": "^2.3.0",
"tailwindcss": "^3.4.4",
"typescript": "^5.5.3"
}
}
6 changes: 3 additions & 3 deletions src/layouts/baseLayout.astro
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import "../styles/global.css";
interface Props {
title: string;
navTitle: string;
}
const { title } = Astro.props;
const { title, navTitle } = Astro.props;
const defaultTitle: string = "Home";
---

<html lang="en">
Expand All @@ -29,7 +29,7 @@ const defaultTitle: string = "Home";
<div class="flex min-h-screen flex-col">
<NavBar
className="fixed top-0 z-30"
pageTitle={title === defaultTitle ? "" : title}
pageTitle={navTitle}
client:load
/>
<main class="mt-16 grow bg-transparent"><slot /></main>
Expand Down
2 changes: 1 addition & 1 deletion src/layouts/seo.astro
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ interface Props {
const { title } = Astro.props;
---

<title>{title} - Fan Control</title>
<title>Fan Control - {title}</title>
<meta name="description" content={seo.description} />
<meta name="image" content={seo.image} />
<meta name="twitter:card" content="summary_large_image" />
Expand Down
2 changes: 1 addition & 1 deletion src/pages/about.astro
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import BaseLayout from "../layouts/baseLayout.astro";
import { AboutPage } from "../reactPages/about";
---

<BaseLayout title="About">
<BaseLayout title="About" navTitle="About">
<AboutPage client:load />
</BaseLayout>
2 changes: 1 addition & 1 deletion src/pages/docs.astro
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import BaseLayout from "../layouts/baseLayout.astro";
import { DocsPage } from "../reactPages/docs";
---

<BaseLayout title="Docs">
<BaseLayout title="Detailed Documentation" navTitle="Docs">
<DocsPage client:load />
</BaseLayout>
2 changes: 1 addition & 1 deletion src/pages/index.astro
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import { IndexPage } from "../reactPages/index";
import BaseLayout from "../layouts/baseLayout.astro";
---

<BaseLayout title="Home">
<BaseLayout title="A highly focused fan controlling software for Windows" navTitle="">
<IndexPage client:load />
</BaseLayout>
11 changes: 7 additions & 4 deletions src/reactPages/about.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import Card from "../reactComponents/card";
import { ExternalLink } from "../reactComponents/links";
import consts from "../common/consts";
import { PageHeader } from "../reactComponents/pageHeader";
import Border from "../reactComponents/border";
import { NiceHeader } from "../reactComponents/niceHeader";
import icons from "../common/icons";

const cardStyle = "bg-white gap-y-2 max-w-full";

Expand All @@ -13,9 +16,9 @@ export const AboutPage = () => {
</div>

<div className="flex flex-wrap gap-4 p-5">
<Card className={cardStyle}>
<div className="text-xl font-medium">Powered by:</div>
<ul className="ml-5 list-disc">
<Border className="max-w-sm">
<NiceHeader text="Powered by:" icon={icons.svgPaths.github} />
<ul className="ml-5 mt-5 list-disc">
{[
consts.urls.lhmGithubPageUrl,
"https://github.com/falahati/NvAPIWrapper",
Expand All @@ -26,7 +29,7 @@ export const AboutPage = () => {
</li>
))}
</ul>
</Card>
</Border>
</div>
</>
);
Expand Down

0 comments on commit f5d0c7b

Please sign in to comment.