Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag - Converted to rich text #838

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SimonFlapse
Copy link
Member

Now prevents creating a tag without an icon.

image
vs
image

On map:
image

On player:
image

Issues:
Discord chat:
image
If these changes were to make it, we'd need to remove the tag from discord

Now prevents creating a tag without an icon.
@SimonFlapse
Copy link
Member Author

Might conflict with #802

@mheguy
Copy link
Member

mheguy commented Mar 1, 2019

I think including images in the names would be cool, but I think that in replacing the text with just an image the meaning becomes much less clear. Is the biter tag for someone killing biters?

@SimonFlapse
Copy link
Member Author

SimonFlapse commented Mar 1, 2019

The biter tag is dog, fish is cat. That's the sprite in the tag gui. Troopers are tanks

@mheguy
Copy link
Member

mheguy commented Mar 1, 2019

It wasn't clear to me that the listing still contained the actual names:
image

I think you should hold off until there is some support on the backend as it makes reading discord and the log nightmarish.

@SimonFlapse
Copy link
Member Author

True :D I added it to diggy because I wanted to play test all the changes. But yeah, no merging before the backend can handle it

@mheguy mheguy added the Waiting on dependency Waiting on another PR to merge label Mar 1, 2019
@SimonFlapse SimonFlapse marked this pull request as draft April 29, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on dependency Waiting on another PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants