Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid as parameter for scanning #129

Closed
wants to merge 5 commits into from

Conversation

vishwaprojects
Copy link

some times we need to scan it dynamically every time its not possible to intiate new bluefalcon instance

@Reedyuk
Copy link
Owner

Reedyuk commented Jun 18, 2024

This wont get merged until you support all of the other platforms with your change.
Some are simple copy of the implementation, others are basic changes.
for example macos implementation you can copy.
Also you should be able to support filtering both service uuid and the optional one you pass in
Please think about the many other people who use this lib and their platforms

@@ -8,6 +8,9 @@ plugins {
id("signing")
}

group = "com.github.vishwaprojects"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you doing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reedyuk i am completely new to github and contributing can you please add uuid in scan function ,immediately need for my project ,BTW i was trying to use mine forked library sorry for that

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I will help you, when I get a moment.
For yourself for now, you can publish using mavenlocal to use it in your project locally, you can do this without your namespace. Just bump the version.

A tip for rookies, your commit message should be descriptive, not random words, it should represent a short summary so that others understand the reason for your change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Reedyuk I tried using maven local as well as jetpack.io but was not successfully eagerly waiting for you to accept my pull request so that it will reflect changes in it and could able to use it

@Reedyuk
Copy link
Owner

Reedyuk commented Jun 19, 2024

What does the comment mann mean? Please make more descriptive commit messages.
I need to change your pull request, before it is merged in.
Why doesn't your maven local not work?

@Reedyuk
Copy link
Owner

Reedyuk commented Jun 19, 2024

Adding maven local as a repository, means the library will pull dependencies from maven local, you must do this change in your project, then you should be able to use it

@vishwaprojects
Copy link
Author

idk i followed through online resourses on web end up getting gradle errors trying since yesterday night ,please do merge asap ,about commit message just kept randomly will keep descriptive commit message let me know do u want any changes from my side

@Reedyuk
Copy link
Owner

Reedyuk commented Jun 19, 2024

This change will break the library for many others, it will not be merged until it is fully working. Please think about other consumers of the library above yourself.
Look at the example projects, these demonstrate how to use maven local.

@Reedyuk
Copy link
Owner

Reedyuk commented Jun 19, 2024

Let me understand your requirements, so you want to scan for different UUID's dynamically instead of on instantiation of blue falcon.

@vishwaprojects
Copy link
Author

@Reedyuk yes instead of in bluefalcon instance i need it dynamicallly

added fixes for examples.
added support to scan with a uuid
@Reedyuk
Copy link
Owner

Reedyuk commented Jun 19, 2024

going to close this in favour of the other pr

@Reedyuk Reedyuk closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants