Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Biograde Link and Update Video Source in Hero Section #55

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

charlottewiltshire0
Copy link
Collaborator

PR Content:

  • Added a link to Biograde in the DownloadHero
  • Updated the video source in the Hero component to use the latest showcase video (showcase_2024.mp4)

@charlottewiltshire0 charlottewiltshire0 added the enhancement New feature or request label Jan 18, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates video source URL in Hero component and adds attribution link to Biograde in the DownloadHero component.

  • Added credit link to Biograde (itch.io game) in /components/sections/download/DownloadHero.tsx with muted styling
  • Updated video source to showcase_2024.mp4 in /components/sections/landing/Hero.tsx for cleaner URL structure
  • Added preload="none" attribute to video element for optimized loading

💡 (5/5) You can turn off certain types of comments like style here!

2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +140 to +142
<p className="mt-2 text-right text-sm text-muted-foreground hover:underline">
<Link href="https://runegamedev.itch.io/biograde">Biograde</Link>
</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: hover:underline is applied to the paragraph instead of the Link component - this means the hover effect will only work when hovering the entire paragraph area rather than just the link text

@@ -84,7 +84,7 @@ export const Hero = () => {
preload="none"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: preload='none' with autoplay may cause a slight delay in video start. Consider using preload='metadata' for faster initial playback

@charlottewiltshire0 charlottewiltshire0 merged commit 75ba1dd into master Jan 18, 2025
5 checks passed
@charlottewiltshire0 charlottewiltshire0 deleted the chore/video-pfp-credit branch January 18, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant