refactor: simplify Banner component structure
#50
Conversation
|
Deploying redot-website with
|
| Latest commit: |
3d93eca
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa1e7302.redot-website.pages.dev |
| Branch Preview URL: | https://chore-banner-background.redot-website.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Simplified the Banner component by removing motion animations and replacing them with CSS transitions, while adding a gradient background and hover effects.
- Removed
framer-motiondependency and"use client"directive from/components/Banner.tsx - Added gradient background styling (
from-pink-500 via-amber-500 to-orange-500) in/components/Banner.tsx - Made
linkprop required and removed conditional rendering ofsubMessagefor simpler implementation - Implemented smooth hover animation using CSS
transition-transformandgroup-hover:translate-x-1classes
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| readonly mainMessage?: string; | ||
| readonly subMessage?: string; | ||
| readonly link?: string; | ||
| readonly link: string; |
There was a problem hiding this comment.
logic: mainMessage is marked optional but required in the implementation (line 15 returns null if !mainMessage). Consider making it required in the interface
| </div> | ||
| <Link href={link} target="_blank" rel="noopener noreferrer"> | ||
| <div className="group flex select-none items-center justify-center gap-2 bg-gradient-to-r from-pink-500 via-amber-500 to-orange-500 py-2 font-sans text-sm font-medium tracking-tight text-white"> | ||
| <p className="hidden md:block">{subMessage}</p> |
There was a problem hiding this comment.
logic: subMessage is rendered unconditionally now - could show empty space if undefined
PR Content:
Old
New