Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for version 7.0-42218 @ DS3615xs #44

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

unknown-o
Copy link
Contributor

Provide 7.0-42218 version support for DS3615xs
Optimize the download extension experience for Chinese users

Copy link

@OrpheeGT OrpheeGT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any added value to use a "chinise mirror source" in official build repo.
Not everyone needs this "chinese mirror source".

@unknown-o
Copy link
Contributor Author

I don't see any added value to use a "chinise mirror source" in official build repo. Not everyone needs this "chinese mirror source".

Hello, the reason why I added the Chinese source is because Github access in China is very unstable, and problems such as connection reset often occur

@OrpheeGT
Copy link

I don't see any added value to use a "chinise mirror source" in official build repo. Not everyone needs this "chinese mirror source".

Hello, the reason why I added the Chinese source is because Github access in China is very unstable, and problems such as connection reset often occur

Maybe but still, I don't see a reason why we should use it worldwide for an issue only for china.

You should better manage a fork repo for chinese peoples.

@unknown-o
Copy link
Contributor Author

I don't see any added value to use a "chinise mirror source" in official build repo. Not everyone needs this "chinese mirror source".

Hello, the reason why I added the Chinese source is because Github access in China is very unstable, and problems such as connection reset often occur

Maybe but still, I don't see a reason why we should use it worldwide for an issue only for china.

You should better manage a fork repo for chinese peoples.

However, there is a high probability that TTG will not merge my branches, so this is not a big problem
And those who want to use it should only download my config file
But next time I submit, I will pay attention to these details

@ttg-public
Copy link
Member

Hm, that's probably an issue with the Chinese firewall. How is CloudFlare working for you guys?

Let's say we use https://rawcdn.githack.com/RedPill-TTG/redpill-virtio/99015c2a67760067bf4e5a1d5cc64b368f615e3f/rpext-index.json - can you wget/curl it multiple times and maybe from multiple locations and see how it performs from China? We don't have anyone physically located behind the China Firewall. If this works we can use githacks as a proxy. It's slightly less convenient as we must always update the hash/tag but as long as CloudFlare works good in China we can have good experience for all countries (as it works great in Eastern Europe and in the US).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants